Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Nov 20, 2020

Issue #, if available:
Refs: aws/aws-sdk-js#3538

Description of changes:
Passes logGroupNamePrefix in describeLogGroups in client-cloudwatch-logs integration tests.

The test fails if there are more than 50 logGroups, as it parses logGroups from
first page of results. This code change explicitly requests for the created logGroup
to ensure it doesn't return pages of results.

Verified that integration tests are successful:

$ yarn test:integration-legacy --tags @cloudwatchlogs 
yarn run v1.22.5
$ cucumber-js --fail-fast --tags @cloudwatchlogs
..........

2 scenarios (2 passed)
6 steps (6 passed)
0m00.095s
Done in 2.80s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…roups

The test fails if there are more than 50 logGroups, as it parses logGroups from
first page of results. This code change explicitly requests for the created logGroup
to ensure it doesn't return pages of results.
@trivikr trivikr requested a review from alexforsyth November 20, 2020 17:30
@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #1708 (840336a) into master (de75f7e) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1708      +/-   ##
==========================================
- Coverage   79.77%   79.76%   -0.02%     
==========================================
  Files         325      329       +4     
  Lines       12087    12575     +488     
  Branches     2553     2672     +119     
==========================================
+ Hits         9643    10030     +387     
- Misses       2444     2545     +101     
Impacted Files Coverage Δ
...tocol_tests/aws-restxml/commands/XmlMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ocol_tests/aws-restxml/commands/XmlListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...col_tests/aws-restjson/commands/JsonMapsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonBlobsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonEnumsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...ol_tests/aws-restjson/commands/JsonListsCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlAttributesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
...tests/aws-restxml/commands/XmlNamespacesCommand.ts 95.65% <0.00%> (-4.35%) ⬇️
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2bc9e...840336a. Read the comment docs.

@trivikr trivikr merged commit 2fe5d14 into aws:master Nov 20, 2020
@trivikr trivikr deleted the update-cloudwatch-integ-test branch November 20, 2020 23:11
@github-actions
Copy link

github-actions bot commented Jan 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants