Skip to content

Conversation

@blake-transcend
Copy link
Contributor

Issue

Description

There is an undeclared dependency on @aws-sdk/protocol-http in https://github.com/blake-transcend/aws-sdk-js-v3/blob/patch-2/packages/middleware-sdk-ec2/src/index.ts#L1. This adds the dependency to the package.json file

Testing

tested locally

Additional context


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 5263faa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr self-requested a review February 19, 2021 16:32
@trivikr trivikr changed the title fix(middleware-sdk-ec2): Add undeclared dependency fix(middleware-sdk-ec2): add undeclared dependency @aws-sdk/protocol-http Feb 19, 2021
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@trivikr trivikr merged commit 6e562ba into aws:master Feb 19, 2021
@blake-transcend blake-transcend deleted the patch-2 branch February 23, 2021 21:11
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants