Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Jun 25, 2021

Issue

Refs: smithy-lang/smithy-typescript#372

Description

Convert second argument of resolve to options

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@93b5cfd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2523   +/-   ##
=======================================
  Coverage        ?   59.55%           
=======================================
  Files           ?      495           
  Lines           ?    26411           
  Branches        ?     6272           
=======================================
  Hits            ?    15729           
  Misses          ?    10682           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b5cfd...08f804d. Read the comment docs.

@trivikr trivikr merged commit df24484 into aws:main Jun 25, 2021
@trivikr trivikr deleted the pass-options-resolve-function branch June 25, 2021 23:55
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants