chore(codegen): refactor generic client configs to separate file #2535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamthom-amzn
approved these changes
Jun 29, 2021
Codecov Report
@@ Coverage Diff @@
## main #2535 +/- ##
=======================================
Coverage ? 60.24%
=======================================
Files ? 513
Lines ? 27359
Branches ? 6577
=======================================
Hits ? 16482
Misses ? 10877
Partials ? 0 Continue to review full report at Codecov.
|
JordonPhillips
approved these changes
Jul 2, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
approved these changes
Jul 8, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored generic client configs to separate file. LMK if you have any naming or other suggestions.
Testing
Ran
yarn generate-clients. Theclientshad a diff where location of serviceId/region moved. Same forprotocol_tests, however it also moved location of some json members likex-bytewhich happened in an earlier PR for me too. Does it happen only for me?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.