chore(clients): call postinstall-node-version-check

[trivikr]

Issue

Internal JS-2727

Description

Calls postinstall-node-version-check in clients

Testing

Tested in package @aws-sdk/client-s3:

$ fnm use 10
Using Node v10.24.1

$ yarn postinstall
yarn run v1.22.10
$ postinstall-node-version-check
(node:21294) NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
no longer support Node.js v10.24.1 as of January 1, 2022.
To continue receiving updates to AWS services, bug fixes, and security
updates please upgrade to Node.js 12.x or later.

More information can be found at: https://a.co/1l6FLnu
Done in 0.11s.

$ fnm use 12
Using Node v12.22.1

$ yarn postinstall
yarn run v1.22.10
$ postinstall-node-version-check
Done in 0.10s.

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[aws-sdk-js-automation]

AWS CodeBuild CI Report

• CodeBuild project: sdk-staging-test
• Commit ID: 9e21f0a
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[trivikr]

The CI failure appears to be some issue with lerna and postinstall scripts.

Observations from running yarn --verbose:

...
Creating symlink at "/local/home/trivikr/workspace/aws-sdk-js-v3/clients/client-sso/node_modules/@aws-sdk/postinstall-node-version-check" to "/local/home/trivikr/workspace/aws-sdk-js-v3/packages/postinstall-node-version-check".
...
Removing extraneous file "/local/home/trivikr/workspace/aws-sdk-js-v3/packages/postinstall-node-version-check/node_modules/.bin".
...
Error: ENOENT: no such file or directory, chmod '/local/home/trivikr/workspace/aws-sdk-js-v3/clients/client-sso/node_modules/.bin/postinstall-node-version-check'

[trivikr]

The CLI failure could be an issue with yarn (legacy) as per the following reports:

• yarn install removing extraneous files when workspaces are enabled yarnpkg/yarn#5580
• Removing extraneous file - I still needed that! yarnpkg/yarn#5230
• Is there a way to stop yarn from auto pruning after install? yarnpkg/yarn#4462

[trivikr]

We'll discuss on 7/18 whether we should publish @aws-sdk/postinstall-node-version-check as a separate packages.
Experimental code using postinstall-node-version-check #2594

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.