Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Jul 26, 2021

Issue

Refs: #2619

Description

Removes unused package postinstall-node-version-check.
The warning will now be emitted in runtimeConfig

Testing

N/A

Additional context

PR which adds emitWarning code in runtimeConfig #2619
Decision when yarn started removing postinstall scripts #2594 (comment)


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 3c1ef7c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@5c9152a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2620   +/-   ##
=======================================
  Coverage        ?   60.61%           
=======================================
  Files           ?      514           
  Lines           ?    27647           
  Branches        ?     6796           
=======================================
  Hits            ?    16758           
  Misses          ?    10889           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9152a...3c1ef7c. Read the comment docs.

@trivikr trivikr merged commit 994386e into aws:main Jul 26, 2021
@trivikr trivikr deleted the remove-postinstall-node-version-check branch July 26, 2021 16:43
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants