Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): set JVM memory size to 4gb #3046

Merged
merged 2 commits into from Dec 9, 2021

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Nov 19, 2021

Description

Codegen throws transient out-of-memory error when generating the biggest model-EC2. Bump up the JVM memory as an workaround.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from a team as a code owner Nov 19, 2021
@AllanZhengYP AllanZhengYP requested a review from mtdowling Nov 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2021

Codecov Report

Merging #3046 (2856c66) into main (dd66d1a) will not change coverage.
The diff coverage is n/a.

Current head 2856c66 differs from pull request most recent head 5acc8b2. Consider uploading reports for the commit 5acc8b2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3046   +/-   ##
=======================================
  Coverage   58.72%   58.72%           
=======================================
  Files         571      571           
  Lines       30620    30620           
  Branches     7541     7541           
=======================================
  Hits        17982    17982           
  Misses      12638    12638           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd66d1a...5acc8b2. Read the comment docs.

JordonPhillips
JordonPhillips previously requested changes Nov 23, 2021
codegen/build.gradle.kts Outdated Show resolved Hide resolved
codegen/build.gradle.kts Outdated Show resolved Hide resolved
@AllanZhengYP AllanZhengYP dismissed JordonPhillips’s stale review Dec 9, 2021

Already approved by Adam

@AllanZhengYP AllanZhengYP merged commit 5c63cef into aws:main Dec 9, 2021
6 checks passed
@github-actions
Copy link

github-actions bot commented Dec 24, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants