Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hash-stream-node): move fileStreamHasher to own file #3086

Merged
merged 5 commits into from Dec 9, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Dec 9, 2021

Issue

Preparing for adding hasher for non-file streams

Description

Moves fileStreamHasher to own file.

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner Dec 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #3086 (9d0a95c) into main (b0e1422) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3086      +/-   ##
==========================================
- Coverage   58.72%   58.72%   -0.01%     
==========================================
  Files         571      571              
  Lines       30622    30620       -2     
  Branches     7541     7541              
==========================================
- Hits        17984    17982       -2     
  Misses      12638    12638              
Impacted Files Coverage Δ
packages/hash-stream-node/src/HashCalculator.ts 90.00% <ø> (ø)
packages/hash-stream-node/src/fileStreamHasher.ts 88.88% <88.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e1422...9d0a95c. Read the comment docs.

@trivikr trivikr requested a review from AllanZhengYP Dec 9, 2021
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Approved. One thing to notice here is that the current file stream hasher returns the hash before the request payload is even start to be sent. However, for a real stream hasher, the hash can only be returned util all the payload stream has been sent. So you cannot use it in the request header. We need to find ways to notify this difference.

@trivikr trivikr merged commit dd66d1a into aws:main Dec 9, 2021
6 checks passed
@trivikr trivikr deleted the hash-stream-node-file-stream-hasher branch Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Dec 24, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants