refactor: track upstream HttpDeserialize changes #1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
approved these changes
Aug 28, 2023
Member
lauzadis
left a comment
lauzadis
left a comment
There was a problem hiding this comment.
Looks good! The batch check failed because ChangeResourceRecordSetsUnmarshallingTest also needs a refactor similar to the GetBucketLocationOperationDeserializerTest you did.
ianbotsf
approved these changes
Aug 28, 2023
| .write("val wrappedResponse = response.#T(payload)", RuntimeTypes.AwsProtocolCore.withPayload) | ||
| writer.write("val payload = call.response.body.#T()", RuntimeTypes.Http.readAll) | ||
| .write("val wrappedResponse = call.response.#T(payload)", RuntimeTypes.AwsProtocolCore.withPayload) | ||
| .write("val wrappedCall = call.copy(response=wrappedResponse)") |
Contributor
There was a problem hiding this comment.
Nit: Spaces around the = operator.
| .write("val wrappedResponse = response.#T(payload)", RuntimeTypes.AwsProtocolCore.withPayload) | ||
| writer.write("val payload = call.response.body.#T()", RuntimeTypes.Http.readAll) | ||
| .write("val wrappedResponse = call.response.#T(payload)", RuntimeTypes.AwsProtocolCore.withPayload) | ||
| .write("val wrappedCall = call.copy(response=wrappedResponse)") |
Contributor
There was a problem hiding this comment.
Nit: Spaces around the = operator.
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
upstream: smithy-lang/smithy-kotlin#939
Description of changes
Track upstream changes to
HttpDeserializebeing refactored to takeHttpCallas an argument rather thanHttpResponseBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.