misc: generate internal-only clients with internal visibility
#1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
commented
Sep 14, 2023
| import java.util.* | ||
|
|
||
| class SmithyKotlinApiSettings : ToNode { | ||
| var visibility: String? = null |
Member
Author
There was a problem hiding this comment.
Note: It's a string here in configuration, but becomes a Visibility enum once it's actually parsed from the Node object
|
Kudos, SonarCloud Quality Gate passed!
|
ianbotsf
approved these changes
Sep 19, 2023
aajtodd
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies
internalvisibility build settings to the internal-only generated SDK clients. It updates the .api file to remove them from the public API.This is technically breaking, but since the classes were all already labeled as "internal", it won't be treated as a breaking change.
Issue #
N/A
Description of changes
This change is required to remove the internal-only clients from the public API.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.