fix: publish service poms with sdkId #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
ianbotsf
approved these changes
Sep 18, 2023
0marperez
approved these changes
Sep 18, 2023
aajtodd
added
the
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
n/a
Description of changes
#1020 refactored the build to use the shared publishing logic. I failed to account for the difference between
aws-sdk-kotlinandsmithy-kotlinpublishing scripts. Previously we published POM files foraws-sdk-kotlinwith an additionalaws.sdk.idproperty. We require this value internally to be set and this PR restores adding it to the generated POM files.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.