Chore refactor ep20 #1052
Merged
Chore refactor ep20 #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
added
the
no-changelog
|
Kudos, SonarCloud Quality Gate passed!
|
aajtodd
approved these changes
Sep 25, 2023
lauzadis
approved these changes
Sep 25, 2023
| import java.util.Properties | ||
| buildscript { | ||
| repositories { | ||
| mavenLocal() |
Member
There was a problem hiding this comment.
Just wondering, why are these new mavenLocal() repositories required?
Contributor
Author
There was a problem hiding this comment.
They're not required but they were convenient while testing the unreleased changes in smithy because I could clone the branch and publish it locally. In general, having mavenLocal() in the repositories list makes development easier and we already have it in several places (e.g., our main build.gradle.kts).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Closes #979
Description of changes
Requisite changes to update to Smithy 1.39.0 including the endpoints changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.