fix: ignore __type when deserializing union for AWS Json protocols #1054
Conversation
| import software.amazon.smithy.model.shapes.MemberShape | ||
| import software.amazon.smithy.model.shapes.Shape | ||
|
|
||
| class AwsJsonProtocolParserGenerator( |
There was a problem hiding this comment.
fix Missing documentation.
Should we rename this (and AwsJsonProtocolSerdeDescriptorGenerator) since these aren't specific to the "aws json" protocols? It's a bit confusing but I also don't know that I have a better suggestion at the moment. At the very least we should document that this isn't specific to awsJson protocols.
| import software.amazon.smithy.model.shapes.MemberShape | ||
| import software.amazon.smithy.model.shapes.Shape | ||
|
|
||
| class AwsJsonProtocolSerdeDescriptorGenerator( |
| { | ||
| "id": "ac672b00-f8bb-4235-8db4-aad0ae2f157d", | ||
| "type": "bugfix", | ||
| "description": "ignore __type when deserializing union for AWS Json protocols", |
There was a problem hiding this comment.
It also applies for RestJSON, so I wouldn't say just "AWS Json protocols"
There was a problem hiding this comment.
nit: consider wrapping __type in backticks: __type
|
|
||
| /** | ||
| * Adds a trait to ignore `__type` in union shapes for `AWS Json 1.0`, `AWS Json 1.1`, `RestJson 1.0` protocols | ||
| * Sometimes the unnecessary trait `__type` is added and needs to be ignored |
There was a problem hiding this comment.
Nit: "Sometimes the unnecessary field `__type` is added and needs to be ignored"
|
SonarCloud Quality Gate failed.
|
4 participants
Issue #
closes #1044
Description of changes
-Added
IgnoreKeywith key__typeto descriptors when deserializing a union shape for AWS Json protocols(AWS Json 1.0, AWS Json 1.1, RestJson 1.0)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.