chore!: refactor urls #1119
Merged
chore!: refactor urls #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view. |
aajtodd
approved these changes
Nov 20, 2023
| } | ||
|
|
||
| /** | ||
| * Percent-encode ISO control characters for the purposes of this specific header. |
lauzadis
approved these changes
Nov 20, 2023
aajtodd
approved these changes
Nov 21, 2023
lauzadis
approved these changes
Nov 21, 2023
… chore-refactor-urls
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Closes smithy-lang/smithy-kotlin#659
Description of changes
Breaking: Pulls in upstream changes which refactor the
Urlclass to be more user-friendly and ergonomic.Companion PR: smithy-lang/smithy-kotlin#989
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.