fix: remove defaults for s3 control #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the members of `PublicAccessBlockConfiguration` to the RemoveDefaults customization. These members are not meant to have a default, as you are meant to be able to configure one member at a time - if you're just trying to turn `BlockPublicAcls` on, you don't want to accidentally turn off `IgnorePublicAcls`. This change makes these members nullable and is a break-fix. Also refactors the map of shapes to remove defaults from to avoid having to call `ShapeId.from` everywhere.
|
A new generated diff is ready to view.
|
…-s3-control-remove-defaults
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view.
|
aajtodd
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
Adds the members of
PublicAccessBlockConfigurationto the RemoveDefaults customization. These members are not meant to have a default, as you are meant to be able to configure one member at a time - if you're just trying to turnBlockPublicAclson, you don't want to accidentally turn offIgnorePublicAcls. This change makes these members nullable and is a break-fix.Also refactors the map of shapes to remove defaults from to avoid having to call
ShapeId.fromeverywhere.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.