fix: override signing config for s3 control #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
|
lauzadis
approved these changes
Jan 22, 2024
Member
lauzadis
left a comment
lauzadis
left a comment
There was a problem hiding this comment.
It would be good to add an E2E test to make sure the operation continues to succeed
| { | ||
| "id": "aef506d4-5c0b-4fa5-ac02-77ff09130875", | ||
| "type": "bugfix", | ||
| "description": "fix missing header (x-amz-content-sha256) in s3 control sigV4 operations", |
Member
There was a problem hiding this comment.
nit: Proper capitalization and add --module s3control flag when creating the changelog to make it service-specific, would appear something like this:
(s3control) Add missing x-amz-content-sha256 header for SigV4 requests
ianbotsf
approved these changes
Jan 22, 2024
|
|
A new generated diff is ready to view.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
closes #1187
Description of changes
Apply the same signing config override that is used for s3 to s3 control
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.