fix: update-release-branch workflow having Gradle URL code changes #1530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
lauzadis
approved these changes
Feb 14, 2025
| run: | | ||
| echo "merging main @ $main_sha into release @ $release_sha"; | ||
| # Getting rid of the changes caused by "Configure Gradle" |
There was a problem hiding this comment.
This comment could be more specific. What changes are being undone, why?
ianbotsf
approved these changes
Feb 14, 2025
Comment on lines
94
to
97
| # Getting rid of the changes caused by "Configure Gradle" | ||
| git stash | ||
There was a problem hiding this comment.
Nit: As noted in offline conversation, git stash -- gradle/wrapper/gradle-wrapper.properties would be a safer command here.
|
|
A new generated diff is ready to view.
|
Affected ArtifactsNo artifacts changed size |
0marperez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Gets rid of changes cause by configure Gradle workflow step
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.