chore: update benchmark README #1559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
A new generated diff is ready to view.
|
xinsong-cui
added
the
no-changelog
lauzadis
approved these changes
Apr 2, 2025
| * `./gradlew :tests:benchmarks:service-benchmarks:bootstrapAll` | ||
| This ensures that all the required service clients are bootstrapped and ready to be built. **You only need to do this | ||
| once** in your workspace unless you clean up generated services or make a change to codegen. | ||
| Ensure all services, including `iam`, have been generated before proceeding with the benchmarks. To run the benchmarks: |
Member
There was a problem hiding this comment.
Just wondering, why does iam need a special callout here?
Contributor
Author
There was a problem hiding this comment.
Oh, It's because iam is not mention in this README, but it was required to bootstrapall: https://github.com/awslabs/aws-sdk-kotlin/blob/7b786d01beee036540e1bb339f313e7b69029abd/tests/benchmarks/service-benchmarks/build.gradle.kts
I was thinking pointing this out would be less confusing.
lauzadis
reviewed
Apr 2, 2025
| ## Instructions | ||
|
|
||
| To run the benchmarks: | ||
| * `./gradlew :tests:benchmarks:service-benchmarks:bootstrapAll` |
Member
There was a problem hiding this comment.
Also note for other reviewers, bootstrapAll was removed in this PR almost a year ago: #1279
Affected ArtifactsNo artifacts changed size |
ianbotsf
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.