-
Notifications
You must be signed in to change notification settings - Fork 55
feat: add support for account ID in IMDS credentials #1573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* close auto-created ImdsClient in default creds chain * adding support for profile settings * removing println calls leftover from debug * rename resolveUnderLock to resolveSingleFlight * add FIXME for static stability messaging/caching in CachedCredentialsProvider * re-adding removed/broken members for API compatibility
|
|
A new generated diff is ready to view.
|
Affected ArtifactsChanged in size
|
lauzadis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending discussion about static stability
0marperez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a little confused by the PR description. It mentions breaking changes but they were removed for this PR right?
Yes they were and I forgot to update the description, which I've now done. There are no breaking changes in this PR. |



Issue #
(none)
Description of changes
Supersedes #1570
This change adds support for sourcing account ID from IMDS credentials.
There are some breaking changes around theThe previous version of this PR (#1570) made breaking changes but this PR avoids them by simply deprecating old declarations and renaming a few things.ImdsCredentialsProviderconstructor to remove no-longer-necessary parameters/fields and forEC2MetadataErrorto more gracefully model HTTP status codes.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.