feat: add JVM property region provider #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
approved these changes
Aug 25, 2021
Comment on lines
-16
to
+25
| public companion object { | ||
| internal const val ACCESS_KEY_ID: String = "AWS_ACCESS_KEY_ID" | ||
| internal const val SECRET_ACCESS_KEY: String = "AWS_SECRET_ACCESS_KEY" | ||
| internal const val SESSION_TOKEN: String = "AWS_SESSION_TOKEN" | ||
| } | ||
|
|
||
| public constructor() : this(Platform::getenv) | ||
|
|
||
| private fun requireEnv(variable: String): String = | ||
| getEnv(variable) ?: throw ConfigurationException("Unable to get value from environment variable $variable") | ||
|
|
||
| override suspend fun getCredentials(): Credentials = Credentials( | ||
| accessKeyId = requireEnv(ACCESS_KEY_ID), | ||
| secretAccessKey = requireEnv(SECRET_ACCESS_KEY), | ||
| sessionToken = getEnv(SESSION_TOKEN), | ||
| accessKeyId = requireEnv(AwsSdkSetting.AwsAccessKeyId.environmentVariable), | ||
| secretAccessKey = requireEnv(AwsSdkSetting.AwsSecretAccessKey.environmentVariable), | ||
| sessionToken = getEnv(AwsSdkSetting.AwsSessionToken.environmentVariable), |
kggilmer
approved these changes
Aug 25, 2021
| /** | ||
| * The name of the corresponding JVM system property that configures the setting | ||
| */ | ||
| public val jvmProperty: String, |
Contributor
There was a problem hiding this comment.
comment
Would we ever have a case for a setting available via environment but not the jvm?
Contributor
Author
There was a problem hiding this comment.
I thought of that and wasn't sure. I slept on it and think the answer is probably no. If there is an environment variable there ought to be a corresponding JVM property. I don't see any cases in the Java SDK where this isn't true FWIW.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
closes #202
Description of changes
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.