chore: clean up publishing workflow #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
The previous checks for group names were spread too many places and requires
afterEvaluateblocks around too much logic. This change hopefully simplifies them into an easier-to-understand configuration.Note:
afterEvaluateis still required around POM configuration. Otherwise, name and description will not be configured properly leading to POM files which fail Nexus's correctness checks.This is the aws-sdk-kotlin-specific version of smithy-kotlin#461.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.