Skip to content

feat(rt): http engine config #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 11, 2021
Merged

feat(rt): http engine config #336

merged 8 commits into from
Oct 11, 2021

Conversation

@aajtodd
Copy link
Contributor

@aajtodd aajtodd commented Oct 8, 2021 •
edited
Loading

Issue #

sibling to smithy-lang/smithy-kotlin#493

Description of changes

  • updates crt engine to use new client engine config
  • defines config for CRT engine that builds on the base config
  • make CRT engine default constructable
  • add imds timeout test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aajtodd aajtodd requested review from ianbotsf and kggilmer October 11, 2021 15:24
@aajtodd aajtodd marked this pull request as ready for review October 11, 2021 15:24
@aajtodd aajtodd merged commit 4d89b3b into main Oct 11, 2021
@aajtodd aajtodd deleted the feat-http-engine-config branch October 11, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianbotsf ianbotsf ianbotsf approved these changes

@kggilmer kggilmer Awaiting requested review from kggilmer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aajtodd @ianbotsf