fix(codegen): use wrapped response when deserializing modeled exceptions #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
aajtodd
requested review from
ianbotsf and
kggilmer
and removed request for
kggilmer
ianbotsf
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
fixes #356
Sibling PR: smithy-lang/smithy-kotlin#505
Description of changes
Render error deserializer with the wrapped response. Previously the original response was being re-used and the error deserializer was calling
response.body.readAll()and getting an empty body because it was already consumed to detect the error code.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.