Skip to content

Conversation

@kggilmer
Copy link
Contributor

@kggilmer kggilmer commented Oct 20, 2021

Companion PRs:

Issue #

Description of changes

  • Update Kotlin and Dokka to 1.5.31 to support documentation generation

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@ianbotsf ianbotsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: While the gradle.properties changes seem fine, I see the version number listed in other places:

Do these locations need to be updated as well?

@aajtodd
Copy link
Contributor

aajtodd commented Oct 21, 2021

Question: While the gradle.properties changes seem fine, I see the version number listed in other places:

* [**build.gradle.kts**](https://github.com/awslabs/aws-sdk-kotlin/blob/main/build.gradle.kts#L8)

* [**examples/build.gradle.kts**](https://github.com/awslabs/aws-sdk-kotlin/blob/main/examples/build.gradle.kts#L2)

Do these locations need to be updated as well?

Good catch. I think (hope) this is irrelevant now since we set the default plugin versions here

@kggilmer kggilmer merged commit 8a933e6 into main Oct 21, 2021
@kggilmer kggilmer deleted the chore-update-kotlin-dokka-version branch October 21, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants