feat(rt): implement retries for imds #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kggilmer
approved these changes
Nov 4, 2021
| status.category() == HttpStatusCode.Category.SERVER_ERROR -> RetryDirective.RetryError(RetryErrorType.ServerSide) | ||
| // 401 indicates the token has expired, this is retryable | ||
| status == HttpStatusCode.Unauthorized -> RetryDirective.RetryError(RetryErrorType.ServerSide) | ||
| else -> RetryDirective.TerminateAndFail |
There was a problem hiding this comment.
suggestion
if it ever happens that we wish to debug why imds didn't retry it would be nice to emit the a log message with the terminating status code.
ianbotsf
approved these changes
Nov 4, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
Finishes the IMDS client implementation by implementing the retry behavior specific to IMDS.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.