Refactor from smithy-kotlin java builder removal #422
Conversation
|
A new generated diff is ready to view: __generated-main...__generated-refactor-remove-java-builders |
|
A new generated diff is ready to view: __generated-main...__generated-refactor-remove-java-builders |
| writer.withBlock("companion object {", "}") { | ||
| withBlock( | ||
| "operator fun invoke(sharedConfig: #T? = null, block: Config.DslBuilder.() -> Unit = {}): #L {", | ||
| "operator fun invoke(sharedConfig: #T? = null, block: Config.Builder.() -> Unit = {}): #L {", |
There was a problem hiding this comment.
same question as sibling PR, should these be inline?
| override fun credentialsProvider(credentialsProvider: CredentialsProvider): FluentBuilder = apply { this.credentialsProvider = credentialsProvider } | ||
| override fun endpointResolver(endpointResolver: AwsEndpointResolver): FluentBuilder = apply { this.endpointResolver = endpointResolver } | ||
| override fun region(region: String): FluentBuilder = apply { this.region = region } | ||
| fun build(): TestPresignConfig = TestPresignConfig(this) |
|
A new generated diff is ready to view: __generated-main...__generated-refactor-remove-java-builders |
|
A new generated diff is ready to view: __generated-main...__generated-refactor-remove-java-builders |
1 similar comment
|
A new generated diff is ready to view: __generated-main...__generated-refactor-remove-java-builders |
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-refactor-remove-java-builders |
3 participants
Companion PR: smithy-lang/smithy-kotlin#534
Issue #
smithy-lang/smithy-kotlin#532
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.