fix(codegen): render default endpoint resolver for machinelearning #424
Conversation
|
A new generated diff is ready to view: __generated-main...__generated-fix-machine-learning |
kggilmer
left a comment
kggilmer
left a comment
There was a problem hiding this comment.
Can you briefly mention testing steps here as I believe we don't have test coverage for this?
| super | ||
| .customizeMiddleware(ctx, resolved) | ||
| .replace(endpointResolverMiddleware) { it is ResolveAwsEndpointMiddleware } | ||
| ): List<ProtocolMiddleware> = resolved + endpointResolverMiddleware |
There was a problem hiding this comment.
question
the custom resolver runs after the default
is enforced here by the fact that endpointResolverMiddleware is the last term here?
There was a problem hiding this comment.
Yes, the endpoint resolver is there by default so this will always run after. The functionality is covered by a protocol test
I generated the machine learning client and noticed not endpoint resolver was registered in any of the operations except |
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-fix-machine-learning |
3 participants
Issue #
fix #423
Description of changes
Ensure a default endpoint resolver is still registered for machine learning. The custom resolver for predict now runs after the default resolver to override the endpoint. We don't currently have a way to replace/override middleware per/operation in codegen.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.