remove middleware Feature concept #425
Conversation
|
A new generated diff is ready to view: __generated-main...__generated-refactor-middleware |
|
A new generated diff is ready to view: __generated-main...__generated-refactor-middleware |
|
A new generated diff is ready to view: __generated-main...__generated-refactor-middleware |
|
A new generated diff is ready to view: __generated-main...__generated-refactor-middleware |
| override fun install(op: SdkHttpOperation<*, *>) { | ||
| op.execution.mutate.register(this, Phase.Order.After) | ||
| } |
There was a problem hiding this comment.
Question: Isn't Order.After the default? How is this different from the default implementation of install?
There was a problem hiding this comment.
I believe it is yes. Probably just a miss, will double check. Good catch
| writer.write("setIfMissing(#S, #S)", it.key, it.value) | ||
| writer.withBlock("op.install(", ")") { | ||
| withBlock("#T().apply {", "}", RuntimeTypes.Http.Middlware.MutateHeadersMiddleware) { | ||
| overrideHeaders.forEach { |
There was a problem hiding this comment.
nit:
I believe you can omit the writer. as your this is the writer via withBlock()
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-refactor-middleware |
3 participants
Issue #
sibling: smithy-lang/smithy-kotlin#536
Description of changes
Updates middleware and codegen to implement upstream interface changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.