Skip to content

Conversation

@kggilmer
Copy link
Contributor

@kggilmer kggilmer commented Dec 1, 2021

Issue #

(none)

Description of changes

  • Was reviewing code against spec and noticed that we still put the signature in the header rather than qs.

Additional Testing

  • presigner tests on polly, sts, s3 continue to pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kggilmer kggilmer requested a review from a team as a code owner December 1, 2021 01:16
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

A new generated diff is ready to view: __generated-main...__generated-fix-presigner-cleanup

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

A new generated diff is ready to view: __generated-main...__generated-fix-presigner-cleanup

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

A new generated diff is ready to view: __generated-main...__generated-fix-presigner-cleanup

@kggilmer kggilmer merged commit 9dc65f9 into main Dec 4, 2021
@kggilmer kggilmer deleted the fix-presigner-cleanup branch December 4, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants