fix(rt): propagate crt stream errors to response body consumer #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-fix-crt-stream-error |
ianbotsf
approved these changes
Jan 26, 2022
kggilmer
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
related to #508
Description of changes
Fixes a bug found in the linked ticket, we need to propagate errors from processing the CRT stream to the response body consumer such that we result in a "failed" channel rather than just a normal closed channel. A normally closed channel results in hard to diagnose errors because the operation looks like it successfully consumes all of the HTTP body when in fact it has not.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.