Skip to content

Conversation

@ianbotsf
Copy link
Contributor

@ianbotsf ianbotsf commented Feb 3, 2022

Issue #

Related to smithy-kotlin#572

Description of changes

This was missed during the refactor of error metadata out of aws-sdk-kotlin into smithy-kotlin. S3ErrorMetadata had a reference to the old namespace for request ID.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ianbotsf ianbotsf requested a review from a team as a code owner February 3, 2022 21:14
@ianbotsf ianbotsf requested review from aajtodd and kggilmer February 3, 2022 21:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ianbotsf ianbotsf merged commit f5ae936 into feat-waiters Feb 3, 2022
@ianbotsf ianbotsf deleted the fix-error-metadata-references branch February 3, 2022 21:52
ianbotsf added a commit that referenced this pull request Feb 4, 2022
* refactor!: update retry namespaces (#504)

* refactor: move request ID and error code metadata to smithy-kotlin (#515)

* fix: update incorrect RequestId error metadata usage in S3 (#518)

* tickle ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants