chore: cleanup presign tests #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view: __generated-main...__generated-fix-presign-tests |
ianbotsf
approved these changes
Mar 11, 2022
Comment on lines
+73
to
83
| client.listObjectsV2Paginated { bucket = bucketName } | ||
| .flatMapConcat { it.contents?.asFlow() ?: flowOf() } | ||
| .collect { obj -> | ||
| val job = scope.launch(dispatcher) { | ||
| client.deleteObject { | ||
| bucket = bucketName | ||
| key = obj.key | ||
| } | ||
| } | ||
| jobs.add(job) | ||
| } |
Contributor
There was a problem hiding this comment.
Nit: Not sure how many objects are being deleted but it would be more efficient to delete them in batches:
client.listObjectsV2Paginated { bucket = bucketName }
.map { page ->
DeleteObjectsRequest {
bucket = bucketName
delete {
objects = page.contents!!.map { obj ->
ObjectIdentifier { key = obj.key }
}
}
}
}
.map { req -> scope.launch { s3.deleteObjects(req) } }
.toList()
.joinAll()
Comment on lines
-43
to
+44
| do { | ||
| val bucketExists = try { | ||
| client.headBucket { bucket = testBucket } | ||
| true | ||
| } catch (ex: NotFound) { | ||
| delay(300) | ||
| false | ||
| } | ||
| } while (!bucketExists) | ||
| client.waitUntilBucketExists { bucket = testBucket } |
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-fix-presign-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speedup presign tests and bucket deletion by order of magnitude + misc cleanup