Skip to content

fix: only set Content-Type when appropriate #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 14, 2022
Merged

fix: only set Content-Type when appropriate #570

merged 9 commits into from
Apr 14, 2022

Conversation

@lucix-aws
Copy link
Contributor

@lucix-aws lucix-aws commented Apr 4, 2022

Protocol tests for Content-Type. Also verifies Content-Length for both cases (body vs. empty).

Issue #

#567

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucix-aws lucix-aws requested a review from a team as a code owner April 4, 2022 17:59
@lucix-aws lucix-aws requested review from aajtodd and ianbotsf April 4, 2022 17:59
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

A new generated diff is ready to view: __generated-main...__generated-fix-set-content-type2

aajtodd
aajtodd approved these changes Apr 4, 2022
View reviewed changes
services/s3/model/s3-tests.smithy
protocol: "aws.protocols#restXml",
method: "PUT",
uri: "/mybucket",
host: "s3.us-west-2.amazonaws.com",
Copy link
Contributor

@aajtodd aajtodd Apr 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to be explicit or at least put a comment in here since we can't actually create this exact request in the real world (anything other than us-east-1 IIRC requires the location constraint which results in a body)

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

A new generated diff is ready to view: __generated-main...__generated-fix-set-content-type2

@github-actions
Copy link

github-actions bot commented Apr 13, 2022

A new generated diff is ready to view: __generated-main...__generated-fix-set-content-type2

@lucix-aws lucix-aws changed the title Protocol tests for Content-Type fix: only set Content-Type when appropriate Apr 14, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Apr 14, 2022

A new generated diff is ready to view: __generated-main...__generated-fix-set-content-type2

@lucix-aws lucix-aws merged commit f5a22c5 into main Apr 14, 2022
@lucix-aws lucix-aws deleted the fix-set-content-type2 branch April 14, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianbotsf ianbotsf ianbotsf approved these changes

+1 more reviewer

@aajtodd aajtodd aajtodd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucix-aws @aajtodd @ianbotsf