Skip to content

Conversation

@aajtodd
Copy link
Contributor

@aajtodd aajtodd commented May 17, 2022

Issue #

sibling: smithy-lang/smithy-kotlin#644

Description of changes

Tracking upstream changes to HttpClientEngine interface from smithy-kotlin
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aajtodd aajtodd requested a review from a team as a code owner May 17, 2022 19:23
@aajtodd aajtodd requested review from ianbotsf and lucix-aws May 17, 2022 19:24
@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-telemetry

@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-telemetry

Copy link
Contributor

@ianbotsf ianbotsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice re-refactor.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@github-actions
Copy link

A new generated diff is ready to view: __generated-main...__generated-telemetry

@aajtodd aajtodd merged commit 8dd6bd0 into main May 20, 2022
@aajtodd aajtodd deleted the telemetry branch May 20, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants