feat: enhance generic codegen to be more KMP-friendly #610
Conversation
|
A new generated diff is ready to view: __generated-main...__generated-feat-kmp-codegen |
aajtodd
left a comment
aajtodd
left a comment
There was a problem hiding this comment.
Looks great. Fix and ship.
NOTE: This should be considered a breaking change and we probably want a more detailed description in the changelog about it. The reason being that the jvm artifact is now -jvm (e.g. s3-jvm) and not the existing artifact (e.g. s3) which is now common.
If you are not using gradle (or the kotlin plugin) you need to pull in the -jvm artifact now. This should be handled automatically for kotlin gradle plugin users.
services/build.gradle.kts
Outdated
| @@ -1,14 +1,19 @@ | |||
| import org.jetbrains.kotlin.gradle.targets.jvm.tasks.KotlinJvmTest | |||
There was a problem hiding this comment.
fix: license header should come first
| // fixes outgoing variant metadata: https://github.com/awslabs/smithy-kotlin/issues/258 | ||
| fun Project.setOutgoingVariantMetadata() { | ||
| tasks.withType<JavaCompile>() { | ||
| val javaVersion = JavaVersion.VERSION_1_8.toString() |
There was a problem hiding this comment.
this probably needs an equivalent somewhere in the kotlin compilation options? It looks like we used to set it on line 78.
|
|
||
| if (testBucket == null) { | ||
| testBucket = prefix + UUID.randomUUID() | ||
| println("Creating S3 bucket: $testBucket") |
There was a problem hiding this comment.
probably be good to add an else branch and print that we are re-using an existing test bucket (which could happen if delete fails or tests are ended abruptly, etc).
|
A new generated diff is ready to view: __generated-main...__generated-feat-kmp-codegen |
|
A new generated diff is ready to view: __generated-main...__generated-feat-kmp-codegen |
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-feat-kmp-codegen |
2 participants
Issue #
Closes #460
Switches to KMP codegen for service clients.
Companion PR: smithy-kotlin#646
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.