test: add multipart upload e2e test coverage #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view: __generated-main...__generated-multipart-e2etest |
|
A new generated diff is ready to view: __generated-main...__generated-multipart-e2etest |
ianbotsf
approved these changes
Jun 3, 2022
Comment on lines
218
to
229
| private fun File.chunk(partSize: Int): Sequence<LongRange> { | ||
| val totalSize = length() | ||
| val firstEndExclusive = minOf(partSize.toLong() + 1, totalSize) | ||
| val seed = 0 until firstEndExclusive | ||
| return generateSequence(seed) { | ||
| if (it.last < totalSize - 1) { | ||
| it.last + 1 until minOf(it.last + partSize.toLong() + 1, totalSize) | ||
| } else { | ||
| null | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: This implementation actually grabs partSize + 1 bytes for the first chunk and then partSize bytes for every subsequent chunk.
Could be rewritten/simplified to:
fun File.chunk(size: Long) =
(0 until length() step size).map {
it until minOf(it + size, length())
}
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-multipart-e2etest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
Added a new e2e test for multipart uploads. I often want to test this feature and always have to go looking for my example. Figure we might as well just add it to our test suite.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.