refactor(rt): use explicit scope for event stream collection #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-explicit-scope |
ianbotsf
approved these changes
Aug 31, 2022
Comment on lines
77
to
79
| writer.write("") | ||
| writer.write("return messages.#T()", AwsRuntimeTypes.AwsEventStream.asEventStreamHttpBody) | ||
| writer.write("return messages.#T(context)", AwsRuntimeTypes.AwsEventStream.asEventStreamHttpBody) | ||
| } |
Contributor
There was a problem hiding this comment.
Question: I'd normally expect a generator change to break some unit tests. Do we not have unit tests for this code?
Contributor
Author
There was a problem hiding this comment.
We have codegen integration tests for event streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#543
sibling: smithy-lang/smithy-kotlin#696
Description of changes
Use an explicit scope for launching background request work
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.