feat: add event stream support #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view: __generated-main...__generated-feat-event-streams2 |
1 task
aajtodd
force-pushed
the
feat-event-streams2
branch
from
d78ebd0 to
8eb18ac
Compare
|
A new generated diff is ready to view: __generated-main...__generated-feat-event-streams2 |
ianbotsf
approved these changes
Sep 8, 2022
Comment on lines
61
to
62
| // simulate async nature of this | ||
| // delay(1000) |
There was a problem hiding this comment.
Question: Is there value in keeping this around? Or can it be deleted?
| }, | ||
| ) | ||
|
|
||
| println("emitting event") |
| is TranscriptResultStream.TranscriptEvent -> { | ||
| event.value.transcript?.results?.forEach { result -> | ||
| val transcript = result.alternatives?.firstOrNull()?.transcript | ||
| println("received TranscriptEvent: isPartial=${result.isPartial}; transcript=$transcript") |
aajtodd
force-pushed
the
feat-event-streams2
branch
from
8eb18ac to
1612b0a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-feat-event-streams2 |
lucix-aws
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
closes #543
Description of changes
Enable event stream operations on all rest protocols. There are only 5 operations today across AWS services that target event streams:
This PR enables support for all but Kinesis which targets the
awsJson1_1protocol. This will require additional follow on work to enable support for RPC based initial event stream request/responses (see #693)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.