chore: upgrade smithy-kotlin version #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
added
the
no-changelog
lucix-aws
approved these changes
Sep 19, 2022
aajtodd
approved these changes
Sep 19, 2022
| # dokka config (values specified at build-time as needed) | ||
| smithyKotlinPackageListUrl= | ||
| smithyKotlinDocBaseUrl=https://docs.aws.amazon.com/sdk-for-kotlin/latest/reference/smithy-kotlin | ||
| smithyKotlinDocBaseUrl=https://docs.aws.amazon.com/sdk-for-kotlin/latest/reference/smithy-kotlin |
Contributor
There was a problem hiding this comment.
FYI this will need to change but it looks like the logic consuming this might be off anyway (would require setting the package list and base URL if I'm not mistaken). We can fix this in next release it will just mean the docs won't link correctly to smithy-kotlin.
|
A new generated diff is ready to view: __generated-main...__generated-chore-update-smithy-kotlin-version |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
Update smithy-kotlin version to just-released 0.12.6.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.