chore: update/clarify changelog and add commit instructions in the Contributing Guidelines #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntributing Guidelines
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-chore-contributing-clarifications |
lauzadis
approved these changes
Sep 23, 2022
|
|
||
| The scope is optional but should be included when possible and refer to a module that is being touched. Examples: | ||
|
|
||
| - codegen |
There was a problem hiding this comment.
Are these scopes relevant for the aws-sdk-kotlin repository?
There was a problem hiding this comment.
Yes they are since this project has both runtime and codegen components, same as smithy-kotlin.
That said, the same scopes are not applicable to the parallel PR in aws-crt-kotlin which effectively contains only runtime components...will revise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
Update and clarify the contributing guidelines to more explicitly detail:
Similar to smithy-lang/smithy-kotlin#706 except also add new commit guidelines.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.