fix(rt): plumb client configuration properties #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
approved these changes
Oct 20, 2022
aajtodd
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Fix and ship.
The codegen diff preview action appears to have a bug in it related to getting the correct version of smithy-kotlin to use. Ignore for now, I'll create an issue for it. (You can also probably change the smithy-kotlin version in gradle.properties to match and it should work again).
| private val profileName: String? = null, | ||
| private val platformProvider: PlatformProvider = Platform, | ||
| httpClientEngine: HttpClientEngine? = null, | ||
| region: String? = null, |
| AWS region to make requests to | ||
| """.trimIndent() | ||
| propertyType = ClientConfigPropertyType.Required() | ||
| order = -1 |
There was a problem hiding this comment.
Same comment as smithy-kotlin, leave yourself some room between the default to allow for insertion of properties in-between these if necessary.
|
Kudos, SonarCloud Quality Gate passed!
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumb client configuration properties through to other client configuration properties
Issue #
#711
Description of changes
When a user specifies an HTTP engine or region in the client configuration, these are not passed through to the CredentialsProvider. This PR passes those configurations to the DefaultCredentialsChainProvider, and also passes
regionfrom the DefaultCredentialsChainProvider to the ProfileCredentialsProvider.Note: if a user specifies a custom CredentialsProvider, they will still need to specify the engine both there and in the general client configuration.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.