Use HashingSource and HashingSink #788
Conversation
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
The failing e2e test is unrelated to this change, and I'm working on fixing it in a separate PR. |
| private fun emptyByteArray(): ByteArray = ByteArray(0) | ||
|
|
||
| // Convert a big-endian ByteArray to an Int | ||
| private fun ByteArray.toInt(): Int { |
There was a problem hiding this comment.
suggestion: you could make this internal and share it with your unit tests
There was a problem hiding this comment.
I removed the .toInt() conversion entirely, now just writing the raw bytes out using write() instead of writeInt()
| "type": "feature", | ||
| "description": "Add usages of HashingSource and HashingSink" |
There was a problem hiding this comment.
Comment: This isn't a great changelog description of the change. Is there a meaningful difference here like performance improvements? If not, this may be something that doesn't deserve a changelog entry.
There was a problem hiding this comment.
Ok, since it's a small change and not really customer-facing (no performance improvements / other effects expected), I will exclude the changelog
| dest.writeInt(sink.crc.toInt()) | ||
| dest.writeInt(sink.digest().toInt()) |
There was a problem hiding this comment.
Question: Why writeInt with a toInt conversion? Why not write which takes a byte array?
There was a problem hiding this comment.
Nice tip, this will work and make it simpler. I was converting the big endian ByteArray to an integer when I could just write the bytes out directly
lauzadis
added
the
no-changelog
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view.
|
3 participants
Change usage of CrcSource/CrcSink to HashingSource and HashingSink.
Issue #
Description of changes
This change is required to use the HashingSource and HashingSink implemented in the
smithy-kotlinpair PR: smithy-lang/smithy-kotlin#756By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.