Add UploadIniaited, Completed, and Failed event progress trackers to SimpleUploadCommand

[GarrettBeatty]

This change creates 3 event progress trackers for SimpleUploadCommand. UploadInitiatedEvent, UploadedCompletedEvent, and UploadFailedEvent. This allows the user to subscribe to events like doing below

        private void uploadStarted(object sender, UploadInitiatedEventArgs args)
         {
             Console.WriteLine($"Upload started: {args.FilePath}");
             Console.WriteLine($"Total size: {args.TotalBytes} bytes");
             Console.WriteLine($"Bucket: {args.Request.BucketName}");
             Console.WriteLine($"Key: {args.Request.Key}");
         }


         TransferUtilityUploadRequest request = new TransferUtilityUploadRequest();
         request.UploadInitiatedEvent += uploadStarted;

These new events should only be fired 1 time during the entire lifecycle of the upload. The details of what each event should contain is in the SEP.

Description

1. DOTNET-8275

Motivation and Context

This is being done as part of the SEP compliance.

Testing

1. Integration tests/unit tests which demonstrate the event handler behavior
2. dry run 0bad1273-f543-4436-bbc9-f76c591bde0a

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• I confirm that this pull request can be released under the Apache 2 license

[Copilot]

Pull Request Overview

This PR implements simple upload progress tracking for the AWS .NET SDK S3 Transfer Utility by adding lifecycle events (initiated, completed, failed) and creating a unified upload response class. It introduces a comprehensive testing framework with JSON-based field mapping validation to ensure response completeness.

Key Changes:

• Added three new lifecycle events (UploadInitiatedEvent, UploadCompletedEvent, UploadFailedEvent) to TransferUtilityUploadRequest
• Created TransferUtilityUploadResponse class to unify response data from different upload operations
• Implemented ResponseMapper utility for mapping S3 response objects to the unified response format

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
TransferUtilityUploadRequest.cs	Added lifecycle event handlers and event argument classes
TransferUtilityUploadResponse.cs	New unified response class with properties mapped from S3 operations
SimpleUploadCommand.cs	Added event firing logic and progress tracking
SimpleUploadCommand.async.cs	Added async event firing and response mapping
ResponseMapper.cs	New utility class for mapping S3 responses to unified format
ResponseMapperTests.cs	Comprehensive test suite with JSON-driven validation
TransferUtilityTests.cs	Integration tests for lifecycle events
AssemblyInfo.cs	Added InternalsVisibleTo for unit testing
mapping.json	JSON configuration defining field mappings between response types
property-aliases.json	Property name aliases for backward compatibility
mapping-schema.json	JSON schema validation for mapping configuration

[Copilot]

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

[Copilot]

The use of Interlocked.Add for thread-safe tracking of transferred bytes is correct, but consider potential race conditions where the final transferred bytes count might not accurately reflect the state at the exact moment of failure in multi-threaded scenarios.

[GarrettBeatty]

not sure if this really matters because this is supposed to be the current moment in time. also multi part upload has been doing this same logic

aws-sdk-net/sdk/src/Services/S3/Custom/Transfer/Internal/MultipartUploadCommand.cs

Line 372 in 9999d23

long transferredBytes = Interlocked.Add(ref _totalTransferredBytes, e.IncrementTransferred - e.CompensationForRetry);

[Copilot]

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

[Copilot]

totalBytes is sourced from _fileTransporterRequest.ContentLength, which is often 0/unspecified for file-path uploads and is set on the underlying PutObjectRequest, not on TransferUtilityUploadRequest. This causes incorrect TotalBytes (and will fail the new tests). Compute the size from the FilePath when present (FileInfo.Length), otherwise fall back to ContentLength (for stream uploads), e.g., introduce a helper GetTotalBytes() and use it here.

[GarrettBeatty]

this isnt a concern because in

aws-sdk-net/sdk/src/Services/S3/Custom/Transfer/TransferUtilityUploadRequest.cs

Line 436 in 9999d23

if (this.IsSetFilePath())

we have logic for this

[Copilot]

[nitpick] Firing the initiated event before constructing the PutObjectRequest makes it harder to provide accurate metadata (like total bytes) if the file size or request normalization occurs during construction. Consider constructing or at least computing total size first, then firing the initiated event so the event carries accurate totals.

Suggested change

	FireTransferInitiatedEvent();
	var putRequest = ConstructRequest();
	var putRequest = ConstructRequest();
	FireTransferInitiatedEvent();

[Copilot]

Using an invalid bucket name triggers client-side validation that can throw ArgumentException instead of AmazonS3Exception, making this test brittle. Use a valid but non-existent bucket name (e.g., conforming to S3 naming rules) and catch AmazonS3Exception, or broaden the catch to Exception to ensure the failed event assertion runs regardless of where the failure occurs.

[GarrettBeatty]

we actually do this in multi part upload command too

aws-sdk-net/sdk/src/Services/S3/Custom/Transfer/Internal/MultipartUploadCommand.cs

Line 83 in 9999d23

this._contentLength = this._fileTransporterRequest.ContentLength;

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.