-
Couldn't load subscription status.
- Fork 867
Add UploadIniaited, Completed, and Failed event progress trackers to SimpleUploadCommand #4039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3d04cf3
701fb99
16f99e1
43b62ab
9bd94c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "services": [ | ||
| { | ||
| "serviceName": "S3", | ||
| "type": "minor", | ||
| "changeLogMessages": [ | ||
| "Added progress tracking events to simple upload" | ||
| ] | ||
| } | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -38,9 +38,20 @@ await this.AsyncThrottler.WaitAsync(cancellationToken) | |||||||||||
| .ConfigureAwait(continueOnCapturedContext: false); | ||||||||||||
| } | ||||||||||||
|
|
||||||||||||
| FireTransferInitiatedEvent(); | ||||||||||||
|
|
||||||||||||
| var putRequest = ConstructRequest(); | ||||||||||||
|
Comment on lines
+41
to
43
|
||||||||||||
| FireTransferInitiatedEvent(); | |
| var putRequest = ConstructRequest(); | |
| var putRequest = ConstructRequest(); | |
| FireTransferInitiatedEvent(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of
Interlocked.Addfor thread-safe tracking of transferred bytes is correct, but consider potential race conditions where the final transferred bytes count might not accurately reflect the state at the exact moment of failure in multi-threaded scenarios.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this really matters because this is supposed to be the current moment in time. also multi part upload has been doing this same logic
aws-sdk-net/sdk/src/Services/S3/Custom/Transfer/Internal/MultipartUploadCommand.cs
Line 372 in 9999d23