-
Notifications
You must be signed in to change notification settings - Fork 867
Add DownloadResponse mapping #4075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/transfermanager
Are you sure you want to change the base?
Conversation
a75c7d4 to
8fab5ec
Compare
0e777fb to
f5b6bfa
Compare
f5b6bfa to
2c12068
Compare
2c12068 to
7caf946
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
7caf946 to
bef9eae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
sdk/src/Services/S3/Custom/Transfer/TransferUtilityDownloadResponse.cs
Outdated
Show resolved
Hide resolved
bef9eae to
be12e1d
Compare
| using Amazon.Runtime; | ||
| using Amazon.S3.Model; | ||
|
|
||
| namespace Amazon.S3.Transfer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eventually this class will be used as the return type of transferUtility.DownloadWithResponseAsync(req)
| // Determine the correct property type for test value generation | ||
| Type propertyTypeForTestValue = sourceProperty?.PropertyType; | ||
|
|
||
| // If direct property doesn't exist but we use headers collection, check Headers collection property type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is needed because we need to write the test value into both the headers and the property value. previously we were writing into the property value and since we didnt write into headers there was a mismatch
stack-info: PR: #4075, branch: GarrettBeatty/stacked/8
be12e1d to
86890ec
Compare
Stacked PRs:
Add GetObjectResponse to TransferUtilityDownloadResponse Mapping
Motivation and Context
To copy all fields to the Transfer Utility Response so we ensure completeness. this is per the SEP compliance design doc
Testing
ffeb46dc-8a09-4558-a777-fb2778601370- passTypes of changes
Checklist
License