-
Notifications
You must be signed in to change notification settings - Fork 867
Add GetObjectResponse to TransferUtilityOpenStreamResponse mapping. #4076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: GarrettBeatty/stacked/8
Are you sure you want to change the base?
Conversation
b444b77 to
44a52b8
Compare
0e777fb to
f5b6bfa
Compare
44a52b8 to
a221d7d
Compare
a221d7d to
da91a90
Compare
| /// <summary> | ||
| /// Maps a GetObjectResponse to TransferUtilityDownloadResponse. | ||
| /// Uses the field mappings defined in mapping.json "Conversion" -> "GetObjectResponse" -> "DownloadResponse". | ||
| /// Private helper method to populate the common properties from GetObjectResponse to the base response class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just making a shared helper function for stream and regular download since they have same response object. the only difference is the stream one has an extra responsestream field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
da91a90 to
09f04c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
09f04c9 to
d682c2d
Compare
| @@ -0,0 +1,293 @@ | |||
| /******************************************************************************* | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made this base class because stream and file based downloads have the same properties. the only difference is openstream command will have extra response stream field
0b181ea to
bceedaf
Compare
stack-info: PR: #4076, branch: GarrettBeatty/stacked/9
bceedaf to
9659acb
Compare
Stacked PRs:
Add GetObjectResponse to TransferUtilityOpenStreamResponse Mapping
Motivation and Context
To copy all fields to the Transfer Utility Response so we ensure completeness.
Testing
46ee0201-7a68-49ad-8f1d-54a60adc7513- passTypes of changes
Checklist
License