Skip to content

Conversation

@GarrettBeatty
Copy link
Contributor

@GarrettBeatty GarrettBeatty commented Oct 23, 2025

Stacked PRs:


Add GetObjectResponse to TransferUtilityOpenStreamResponse Mapping

Motivation and Context

To copy all fields to the Transfer Utility Response so we ensure completeness.

Testing

  1. ran test locally
  2. 46ee0201-7a68-49ad-8f1d-54a60adc7513 - pass

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/9 branch from b444b77 to 44a52b8 Compare October 23, 2025 17:37
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/8 branch from 0e777fb to f5b6bfa Compare October 23, 2025 17:37
@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/8 to feature/transfermanager October 23, 2025 17:39
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/9 branch from 44a52b8 to a221d7d Compare October 23, 2025 17:39
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/8 October 23, 2025 17:40
@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/8 to feature/transfermanager October 23, 2025 17:52
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/9 branch from a221d7d to da91a90 Compare October 23, 2025 17:52
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/8 October 23, 2025 17:52
/// <summary>
/// Maps a GetObjectResponse to TransferUtilityDownloadResponse.
/// Uses the field mappings defined in mapping.json "Conversion" -> "GetObjectResponse" -> "DownloadResponse".
/// Private helper method to populate the common properties from GetObjectResponse to the base response class.
Copy link
Contributor Author

@GarrettBeatty GarrettBeatty Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just making a shared helper function for stream and regular download since they have same response object. the only difference is the stream one has an extra responsestream field.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/8 to feature/transfermanager October 23, 2025 23:53
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/9 branch from da91a90 to 09f04c9 Compare October 23, 2025 23:53
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/8 October 23, 2025 23:54
@GarrettBeatty GarrettBeatty requested a review from Copilot October 24, 2025 00:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/8 to feature/transfermanager October 24, 2025 13:48
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/9 branch from 09f04c9 to d682c2d Compare October 24, 2025 13:48
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/8 October 24, 2025 13:49
@GarrettBeatty GarrettBeatty marked this pull request as ready for review October 24, 2025 13:52
@GarrettBeatty GarrettBeatty changed the title Add GetObjectResponse to TransferUtilityDownloadResponse mapping. Add GetObjectResponse to TransferUtilityOpenStreamResponse mapping. Oct 24, 2025
@@ -0,0 +1,293 @@
/*******************************************************************************
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made this base class because stream and file based downloads have the same properties. the only difference is openstream command will have extra response stream field

@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/8 to feature/transfermanager October 24, 2025 14:57
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/9 branch from 0b181ea to bceedaf Compare October 24, 2025 14:57
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/8 October 24, 2025 14:57
@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/8 to feature/transfermanager October 24, 2025 15:17
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/8 October 24, 2025 15:18
@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/8 to feature/transfermanager October 24, 2025 15:46
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/8 October 24, 2025 15:46
@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/8 to feature/transfermanager October 24, 2025 16:19
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/8 October 24, 2025 16:19
stack-info: PR: #4076, branch: GarrettBeatty/stacked/9
@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/8 to feature/transfermanager October 24, 2025 22:24
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/9 branch from bceedaf to 9659acb Compare October 24, 2025 22:24
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/8 October 24, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant