[V4] Rename ErrorType exception properties to avoid hiding inherited member #4088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-othman
changed the title
peterrsongg
requested changes
Oct 30, 2025
| /// A string containing the overridden property name if a special case applies, | ||
| /// or null if the default property name should be used. | ||
| /// </returns> | ||
| private string GetPropertyNameOverride() |
There was a problem hiding this comment.
same comment as V3 on the name of the method
peterrsongg
approved these changes
Oct 31, 2025
muhammad-othman
force-pushed
the
muhamoth/DOTNET-8305-ErrorType-property-in-exception-shapes-are-failing
branch
from
b9568ad to
2fe646a
Compare
dscpinheiro
approved these changes
Nov 3, 2025
dscpinheiro
deleted the
muhamoth/DOTNET-8305-ErrorType-property-in-exception-shapes-are-failing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change resolves a naming conflict in exception classes where the
ErrorTypeproperty could hide the inheritedErrorTypemember from the baseAmazonServiceExceptionclass.Also removed previous customization approach at
AccountServicein favor of the generator-level fix, which caused the private property name to change but the pubic properties stayed that same.Motivation and Context
DOTNET-8305Testing
AccountServicewas affect by this change.DRY_RUN-3f60b43c-dedc-49b2-8e2d-1afc309f4889Screenshots (if appropriate)
Types of changes
Checklist
License