Generate CreateBucketMetadataTableConfiguration

[peterrsongg]

Description

Generates CreateBucketMetadataTableConfiguration

AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.RecordExpiration/MethodRemoved: Missing method System.Void set_Days(System.Int32) in Amazon.S3.Model.RecordExpiration
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.RecordExpiration/MethodAdded: New method System.Void set_Days(System.Nullable<System.Int32>) in Amazon.S3.Model.RecordExpiration
AssemblyComparer AWSSDK.S3.New.dll: Error Amazon.S3.Model.RecordExpiration/MethodRemoved: Missing method System.Int32 get_Days() in Amazon.S3.Model.RecordExpiration
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.RecordExpiration/MethodAdded: New method System.Nullable<System.Int32> get_Days() in Amazon.S3.Model.RecordExpiration

Amazon.S3.Model.RecordExpiration Days property changed from int to int? will call this out in changelog

Motivation and Context

Testing

Dry run passed
Fuzz tests ran no change

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• I confirm that this pull request can be released under the Apache 2 license

[peterrsongg]

READ THIS

• Changing int to int? is something we've done in other PR's. This follows the nullability pattern for the sdk that we just missed here because it is handcoded.

---

Files Analyzed: 9 out of 9 files changed in this PR

BREAKING CHANGES FOUND:

1. RecordExpiration.cs - CRITICAL BREAKING CHANGE

File: sdk/src/Services/S3/Generated/Model/RecordExpiration.cs

Issue: The Days property type changed from non-nullable int to nullable int?

Custom version (deleted):

public int Days
{
    get { return this._days.GetValueOrDefault(); }
    set { this._days = value; }
}

Generated version (new):

public int? Days
{
    get { return this._days; }
    set { this._days = value; }
}

Impact: This is a breaking change to the public API. Code that previously worked with int Days will break when trying to use int? Days. Existing code that accesses Days without null checking will fail at runtime if the value is null, or will not compile if assigned to non-nullable int variables.

Example Breaking Scenario:

// Old code that will break:
RecordExpiration expiration = new RecordExpiration();
int days = expiration.Days; // Compilation error: Cannot implicitly convert type 'int?' to 'int'

// Or runtime issue:
int daysValue = expiration.Days.Value; // Could throw InvalidOperationException if null

---

NO OTHER BREAKING CHANGES DETECTED IN:

1. ✅ CreateBucketMetadataConfigurationRequest.cs - All IsSet methods use !String.IsNullOrEmpty() as expected (matches customizations.json configuration)
2. ✅ CreateBucketMetadataConfigurationResponse.cs - Empty response class, no breaking changes
3. ✅ CreateBucketMetadataConfigurationRequestMarshaller.cs - No custom version existed, purely generated
4. ✅ CreateBucketMetadataConfigurationResponseUnmarshaller.cs - No custom version existed, purely generated
5. ✅ InventoryTableConfiguration.cs - Properties and IsSet methods match
6. ✅ JournalTableConfiguration.cs - Properties and IsSet methods match
7. ✅ MetadataConfiguration.cs - Properties and IsSet methods match
8. ✅ MetadataTableEncryptionConfiguration.cs - Only private field naming changed (kmsKeyArn → _kmsKeyArn), public API unchanged

---

Summary:

• Total Files Changed: 9
• Files Analyzed: 9
• Breaking Changes Found: 1 (RecordExpiration.Days property type change)
• Status: ❌ BREAKING CHANGES DETECTED - REQUIRES IMMEDIATE ATTENTION