Skip to content

fix build. #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2025
Merged

fix build. #4192

merged 2 commits into from
Dec 3, 2025
+4 −6

Conversation

@GarrettBeatty
Copy link
Contributor

@GarrettBeatty GarrettBeatty commented Dec 3, 2025 •
edited
Loading 

Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [C:\codebuild\tmp\output\src1347746254\src\aws-sdk-net\sdk\src\Services\S3\AWSSDK.S3.NetStandard.csproj::TargetFramework=netcoreapp3.1]

was not happening on my local machine since im on dotnet 10 dotnet/roslyn#77001. this fixes this issue. i used a global.json with dotnet 8 to ensure there are no more build errors. i re-ran the unit and integ tests too

@GarrettBeatty GarrettBeatty merged commit 7f64813 into feature/transfermanager Dec 3, 2025
1 check passed
@GarrettBeatty GarrettBeatty deleted the gcbeatty/testfix3 branch December 3, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dscpinheiro dscpinheiro dscpinheiro approved these changes

@AlexDaines AlexDaines AlexDaines approved these changes

@philasmar philasmar Awaiting requested review from philasmar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GarrettBeatty @dscpinheiro @AlexDaines