-
Notifications
You must be signed in to change notification settings - Fork 722
Closed
Labels
documentationImprovement or bugfixes on docsImprovement or bugfixes on docsenhancementNew feature or requestNew feature or request
Description
Is your idea related to a problem? Please describe.
I found the following issues with the contributing guidelines:
- When deploying
aws-data-wrangler-databases, CloudFormation failed when creating theCodeBuildTestRoleLFPermissionsresource withResource does not exist or requester is not authorized to access requested permissions.. The issue was that the IAM role used to create the CloudFormation stack did not have Lake Formation permission needed to grant permissions. - With the full test environment, the guide specific that running
pytest -n 8 tests/test_db.pywill run all the database related tests. However,test_db.pydoes not exist.
Describe the solution you'd like
- An entry could be added to the CONTRIBUTING_COMMON_ERRORS page which specifies that the IAM role used by CloudFormation needs to be added as a Lake Formation admin. The troubleshooting guide can say "find the role prefixed with
cdk-hnb659fds-cfn-exec-role-and add it as an admin". - Update the guidelines to specify the proper unit test file
malachi-constant
Metadata
Metadata
Assignees
Labels
documentationImprovement or bugfixes on docsImprovement or bugfixes on docsenhancementNew feature or requestNew feature or request